Preserve TOC insert API compatibility by pathscale · Pull Request #64 · pathscale/WorkTable

pathscale · 2026-08-08T14:26:50Z

Summary

restore the historical infallible IndexTableOfContents::insert return type
expose try_insert for persistence paths that can report a truncated chain
retain PR fix: keep TOC reload insertion on the fast path #63’s non-mutating capacity checks and O(1)-segment common path

resolves the public API compatibility finding from PR fix: keep TOC reload insertion on the fast path #63
does not reintroduce the duplicate sweep: all current persistence callers insert fresh page identities, and the historical pre-fix: carry TOC inserts across persisted segments #62 API did not replace identities

cargo test --workspace --all-features (523 integration tests + workspace/unit/doc tests pass)
cargo clippy --workspace --all-targets --all-features -- -D warnings

pathscale · 2026-08-08T17:41:13Z

Review-round update

Clarified that insert restores the public infallible contract from before PR fix: keep TOC reload insertion on the fast path #63, while loaded persistence paths use try_insert for reportable truncation.
Documented the unit binding as a compile-time source-compatibility regression.
Focused TOC verification: 7 unit tests plus 17 integration tests passed; strict workspace all-target/all-feature Clippy passed.
Paired wt-benchmarks comparison against base d80d834: 20 samples per KV operation with identical checksums. Median throughput deltas were insert +1.21%, point read +1.32%, overwrite +0.17%, range scan -2.64%, and delete -0.93%.
Persisted 2,000-row load/churn/vacuum/reload passed on both base and head with identical 1,500 reloaded rows, file counts, file sizes, and vacuum statistics.

No correctness or material performance regression observed.

meh added 2 commits August 8, 2026 21:26

fix: preserve TOC insert API compatibility

029866a

docs: pin TOC compatibility contract

ebd4aa8

pathscale merged commit ab218be into master Aug 8, 2026
9 of 10 checks passed

pathscale deleted the fix/toc-insert-api-compat branch August 8, 2026 17:55